Changeset 1246

Timestamp:

01/09/10 17:56:39 (8 months ago)

Author:

astrange

Message:

Reformat FIXME/TODO comments to show up in Xcode browser menu.

Closes #451.

Location:

trunk

Files:

• CPFPerianPrefPaneController.m (modified) (1 diff)
• ColorConversions.c (modified) (2 diffs)
• FFissionCodec/FFissionDecoder.cpp (modified) (1 diff)
• FFusionCodec.c (modified) (1 diff)
• MatroskaCodecIDs.cpp (modified) (1 diff)
• MatroskaImportPrivate.cpp (modified) (3 diffs)
• Subtitles/SubATSUIRenderer.m (modified) (9 diffs)
• Subtitles/SubRenderer.h (modified) (1 diff)
• TextSubCodec.c (modified) (1 diff)
• bitstream_info.c (modified) (1 diff)
• codecList.m4 (modified) (1 diff)
• ff_private.c (modified) (6 diffs)

trunk/CPFPerianPrefPaneController.m

@@ -852 +852 @@
         NSString *status = [notification object];
         
-        //FIXME localize these
+        //FIXME: localize these
         if ([status isEqualToString:@"Starting"]) {
                 [textField_updateStatus setStringValue:@"Checking..."];

trunk/ColorConversions.c

@@ -40 +40 @@
 
 //Handles the last row for Y420 videos with an odd number of luma rows
-//FIXME odd number of luma columns is not handled and they will be lost
+//FIXME: odd number of luma columns is not handled and they will be lost
 static void Y420toY422_lastrow(UInt8 *o, UInt8 *yc, UInt8 *uc, UInt8 *vc, unsigned halfWidth)
 {
@@ -514 +514 @@
                         return k16BE555PixelFormat;
                 case PIX_FMT_BGR24:
-                        return k24RGBPixelFormat; //XXX try k24BGRPixelFormat
+                        return k24RGBPixelFormat; //FIXME: try k24BGRPixelFormat
                 case PIX_FMT_RGB24:
                         return k24RGBPixelFormat;
-                case PIX_FMT_RGB32: // XXX not a specific pixel format, need LE & BE like 16-bit
+                case PIX_FMT_RGB32: // FIXME: not a specific pixel format, need LE & BE like 16-bit
                         return k32ARGBPixelFormat;
                 case PIX_FMT_YUV410P:

trunk/FFissionCodec/FFissionDecoder.cpp

@@ -68 +68 @@
 //CA tends to not set the magic cookie immediately, but we need it to open most codecs
 //so check this to not open the codec until it's possible
-//FIXME or we could just open the codec and ignore errors?
 static bool CodecRequiresExtradata(OSType formatID)
 {

trunk/FFusionCodec.c

@@ -618 +618 @@
                 
                 // official Apple/QT/ISO/etc fourccs are likely to have PTS vs DTS defined
-                // FIXME what this actually checks is whether the file has a 'ctts' atom, can we do that directly?
+                // FIXME: what this actually checks is whether the file has a 'ctts' atom, can we do that directly?
                 if(componentType == kMPEG4VisualCodecType || componentType == kH264CodecType ||
                    componentType == kMPEG1VisualCodecType || componentType == kMPEG2VisualCodecType)

trunk/MatroskaCodecIDs.cpp

@@ -504 +504 @@
         
         // vosLen > 2 means SBR; some of those must be rewritten to avoid QT bugs(?)
-        // FIXME remove when QT works with them
+        // FIXME: remove when QT works with them
         if (audio && (!vosBuf || vosLen > 2)) {
                 RecreateAACVOS(tr_entry, aacBuf, &vosLen);

trunk/MatroskaImportPrivate.cpp

@@ -373 +373 @@
         // ensure that at least one track of each media type is enabled, if none were originally
         // this picks the first track, which may not be the best, but the situation is quite rare anyway
-        // FIXME properly choose tracks based on forced/default/language flags, and consider turning auto-alternates back on
+        // FIXME: properly choose tracks based on forced/default/language flags, and consider turning auto-alternates back on
         if (!videoEnabled && firstVideoTrack)
                 SetTrackEnabled(firstVideoTrack, 1);
@@ -547 +547 @@
                 asbd.mFramesPerPacket = 1152;
         
-        // FIXME mChannelLayoutTag == 0 is valid
+        // FIXME: mChannelLayoutTag == 0 is valid
         // but we don't use channel position lists (yet) so it's safe for now
         if (acl.mChannelLayoutTag == 0) acl = GetDefaultChannelLayout(&asbd);
@@ -634 +634 @@
         } else if ((*imgDesc)->cType == kSubFormatUTF8 || (*imgDesc)->cType == kSubFormatSSA || (*imgDesc)->cType == kSubFormatASS) {
                 if ((*imgDesc)->cType == kSubFormatASS) (*imgDesc)->cType = kSubFormatSSA; // no real reason to treat them differently
-                UInt32 emptyDataRefExtension[2]; // XXX the various uses of this bit of code should be unified
+                UInt32 emptyDataRefExtension[2]; // FIXME: the various uses of this bit of code should be unified
                 mkvTrack.subDataRefHandler = NewHandleClear(sizeof(Handle) + 1);
                 emptyDataRefExtension[0] = EndianU32_NtoB(sizeof(UInt32)*2);

trunk/Subtitles/SubATSUIRenderer.m

@@ -263 +263 @@
 }
 
-// XXX: Assumes ATSUFontID = ATSFontRef. This is true.
+// Assumes ATSUFontID = ATSFontRef. This is true.
 static ATSUFontID GetFontIDForSSAName(NSString *name)
 {       
@@ -355 +355 @@
         
         if (!s->platformSizeScale) s->platformSizeScale = GetWinFontSizeScale(fontRef);
-        size = FloatToFixed(s->size * s->platformSizeScale * screenScaleY); //FIXME several other values also change relative to PlayRes but aren't handled
+        size = FloatToFixed(s->size * s->platformSizeScale * screenScaleY); //FIXME: several other values also change relative to PlayRes but aren't handled
         
         ATSUCreateStyle(&style);
@@ -440 +440 @@
         switch (tag) {
                 case tag_b:
-                        bv(); // XXX font weight variations
+                        bv(); // FIXME: font weight variations
                         SetATSUStyleFlag(spanEx->style, kATSUQDBoldfaceTag, bval != 0);
                         break; 
@@ -555 +555 @@
                 case tag_be:
                         bv();
-                        if (!isFirstSpan) div->render_complexity |= renderMultipleParts; // XXX blur edges
+                        if (!isFirstSpan) div->render_complexity |= renderMultipleParts; //FIXME: blur edges
                         spanEx->blurEdges = bval;
                         break;
@@ -565 +565 @@
 #pragma mark Rendering Helper Functions
 
-// XXX see comment for GetTypographicRectangleForLayout
+// see comment for GetTypographicRectangleForLayout
 static ATSUTextMeasurement GetLineHeight(ATSUTextLayout layout, UniCharArrayOffset lpos, Boolean includeDescent)
 {
@@ -584 +584 @@
 }
 
-// XXX some broken fonts have very wrong typographic values set, and so this occasionally gives nonsense
+// some broken fonts have very wrong typographic values set, and so this occasionally gives nonsense
 // it should be checked against the real pixel box (see #if 0 below), but for correct fonts it looks much better
 static void GetTypographicRectangleForLayout(ATSUTextLayout layout, UniCharArrayOffset *breaks, ItemCount breakCount, Fixed extraHeight, Fixed *lX, Fixed *lY, Fixed *height, Fixed *width)
@@ -955 +955 @@
         //ATS bug(?) with some fonts:
         //drawing \n draws some random other character, so skip them
-        //XXX maybe don't store newlines in div->text at all
+        //FIXME: maybe don't store newlines in div->text at all
         if ([div->text characterAtIndex:thisBreak+lineLen-1] == '\n') {
                 lineLen--;
@@ -1001 +1001 @@
                         
                         //linear search for the next span to draw
-                        //XXX not at all sure how this works or if it's correct
+                        //FIXME: make sure this never skips any spans
                         for (j = 0; j < nspans; j++) {
                                 SubRenderSpan *span = [div->spans objectAtIndex:j];
@@ -1370 +1370 @@
 // Windows and OS X use different TrueType fields to measure text.
 // Some Windows fonts have one field set incorrectly(?), so we have to compensate.
-// XXX This function doesn't read from the right fonts; if we're using italic variant, it should get the ATSFontRef for that
-// XXX^2 This should be cached
+// FIXME: This function doesn't read from the right fonts; if we're using italic variant, it should get the ATSFontRef for that
+// This should be cached
 static float GetWinFontSizeScale(ATSFontRef font)
 {

trunk/Subtitles/SubRenderer.h

@@ -37 +37 @@
 #endif
 
-// XXX these should be 'id' instead of 'void*' but it makes it easier to use ATSUStyle
+// these should be 'id' instead of 'void*' but it makes it easier to use ATSUStyle
 @interface SubRenderer : NSObject
 -(void)completedHeaderParsing:(SubContext*)sc;

trunk/TextSubCodec.c

@@ -222 +222 @@
     
     // we want ARGB because Quartz can use it easily
-    // Todo: add other possible pixel formats Quartz can handle
     *formats++  = k32RGBAPixelFormat;
         *formats++      = k32ARGBPixelFormat;

trunk/bitstream_info.c

@@ -1030 +1030 @@
                 //QT is bad at high profile
                 //and x264 B-pyramid (sps.vui.num_reorder_frames > 1)
-                //FIXME x264 will generate pyramid differently soon (core 78+), and that might work better
                 if(h264parser->profile_idc < 100 && h264parser->num_reorder_frames < 2 && 
                    !CFPreferencesGetAppBooleanValue(CFSTR("DecodeAllProfiles"), PERIAN_PREF_DOMAIN, NULL))

trunk/codecList.m4

@@ -8 +8 @@
 Codec(kXVIDCodecInfoResID, CODEC_ID_MPEG4, "Xvid", "Decompresses video stored in Xvid format.", 'XVID', 'xvid', 'XviD', 'XVIX', 'BLZ0')
 Codec(kMPEG4CodecInfoResID, CODEC_ID_MPEG4, "MPEG-4", "Decompresses video stored in MPEG-4 format.", 'RMP4', 'SEDG', 'WV1F', 'FMP4', 'SMP4')
-ResourceOnly(<!// XXX: can we do this without claiming Apple's manufacturer (and thus unregistering their decoder)?!>)
+ResourceOnly(<!// FIXME: can we do this without claiming Apple's manufacturer (and thus unregistering their decoder)?!>)
 ResourceOnly(<!#define kCodecManufacturer 'appl'!>)
 ResourceOnly(<!#define kCodecVersion kFFusionCodecVersion + 0x10!>)

trunk/ff_private.c

@@ -126 +126 @@
         av_reduce(&base->num, &base->den, base->num, base->den, INT_MAX);
         
-        if (base->num == 1) return; // XXX is this good enough?
+        if (base->num == 1) return; // FIXME: is this good enough?
         
         double fTimebase = av_q2d(*base), nearest_ntsc = floor(fTimebase * 1001. + .5) / 1001.;
@@ -188 +188 @@
         
         // 12 is invalid in mov
-        // XXX it might be better to set this based entirely on pix_fmt
+        // FIXME: it might be better to set this based entirely on pix_fmt
         if ((*imgHdl)->depth == 12 || (*imgHdl)->depth == 0) (*imgHdl)->depth = codec->pix_fmt == PIX_FMT_YUVA420P ? 32 : 24;
         
@@ -228 +228 @@
         
         /* Ask the AudioToolbox about vbr of the codec */
-        // FIXME this sets vbr even if it was encoded in CBR mode
+        // FIXME: this sets vbr even if it was encoded in CBR mode
         // which means our mBytesPerPacket is wrong for CBR mp3 (does not really matter)
         ioSize = sizeof(UInt32);
@@ -281 +281 @@
                 asbd.mFramesPerPacket = 1;
         else if (asbd.mBytesPerPacket) {
-                /* FIXME. in the MSADPCM codec, we get a wrong mFramesPerPacket entry because
+                /* FIXME: in the MSADPCM codec, we get a wrong mFramesPerPacket entry because
                  * of the difference in the sample_rate and the time_base denumerator. So we
                  * recalculate here the mFramesPerPacket entry */
@@ -619 +619 @@
 
 // Create the 'nclc' atom for video tracks. Guessed entirely from image size following ffdshow.
-// FIXME read H.264 VUI/MPEG2 etc and especially read chroma positioning information.
+// FIXME: read H.264 VUI/MPEG2 etc and especially read chroma positioning information.
 // this needs the parsers working
 // References: http://developer.apple.com/quicktime/icefloe/dispatch019.html
@@ -690 +690 @@
                         track = NewMovieTrack(theMovie, width, height, kNoVolume);
 
-            // XXX Support for 'old' NUV files, that didn't put the codec_tag in the file. 
+            // Support for 'old' NUV files, that didn't put the codec_tag in the file. 
             if( st->codec->codec_id == CODEC_ID_NUV && st->codec->codec_tag == 0 ) {
                 st->codec->codec_tag = MKTAG( 'N', 'U', 'V', '1' );