Changeset 1246

Timestamp:

01/09/10 17:56:39 (2 months ago)

Author:

astrange

Message:

Reformat FIXME/TODO comments to show up in Xcode browser menu.

Closes #451.

Files:

• trunk/CPFPerianPrefPaneController.m (modified) (1 diff)
• trunk/ColorConversions.c (modified) (2 diffs)
• trunk/FFissionCodec/FFissionDecoder.cpp (modified) (1 diff)
• trunk/FFusionCodec.c (modified) (1 diff)
• trunk/MatroskaCodecIDs.cpp (modified) (1 diff)
• trunk/MatroskaImportPrivate.cpp (modified) (3 diffs)
• trunk/Subtitles/SubATSUIRenderer.m (modified) (9 diffs)
• trunk/Subtitles/SubRenderer.h (modified) (1 diff)
• trunk/TextSubCodec.c (modified) (1 diff)
• trunk/bitstream_info.c (modified) (1 diff)
• trunk/codecList.m4 (modified) (1 diff)
• trunk/ff_private.c (modified) (6 diffs)

trunk/CPFPerianPrefPaneController.m

@@ -852 +852 @@
-        NSString *status = [notification object];
-        
-
+:
-        if ([status isEqualToString:@"Starting"]) {
-                [textField_updateStatus setStringValue:@"Checking..."];

trunk/ColorConversions.c

@@ -40 +40 @@
-
-//Handles the last row for Y420 videos with an odd number of luma rows
-
+:
-static void Y420toY422_lastrow(UInt8 *o, UInt8 *yc, UInt8 *uc, UInt8 *vc, unsigned halfWidth)
-{
@@ -514 +514 @@
-                        return k16BE555PixelFormat;
-                case PIX_FMT_BGR24:
-XXX
+FIXME:
-                case PIX_FMT_RGB24:
-                        return k24RGBPixelFormat;
-XXX
+FIXME:
-                        return k32ARGBPixelFormat;
-                case PIX_FMT_YUV410P:

trunk/FFissionCodec/FFissionDecoder.cpp

@@ -68 +68 @@
-//CA tends to not set the magic cookie immediately, but we need it to open most codecs
-//so check this to not open the codec until it's possible
-//FIXME or we could just open the codec and ignore errors?
-static bool CodecRequiresExtradata(OSType formatID)
-{

trunk/FFusionCodec.c

@@ -618 +618 @@
-                
-                // official Apple/QT/ISO/etc fourccs are likely to have PTS vs DTS defined
-
+:
-                if(componentType == kMPEG4VisualCodecType || componentType == kH264CodecType ||
-                   componentType == kMPEG1VisualCodecType || componentType == kMPEG2VisualCodecType)

trunk/MatroskaCodecIDs.cpp

@@ -504 +504 @@
-        
-        // vosLen > 2 means SBR; some of those must be rewritten to avoid QT bugs(?)
-
+:
-        if (audio && (!vosBuf || vosLen > 2)) {
-                RecreateAACVOS(tr_entry, aacBuf, &vosLen);

trunk/MatroskaImportPrivate.cpp

@@ -373 +373 @@
-        // ensure that at least one track of each media type is enabled, if none were originally
-        // this picks the first track, which may not be the best, but the situation is quite rare anyway
-
+:
-        if (!videoEnabled && firstVideoTrack)
-                SetTrackEnabled(firstVideoTrack, 1);
@@ -547 +547 @@
-                asbd.mFramesPerPacket = 1152;
-        
-
+:
-        // but we don't use channel position lists (yet) so it's safe for now
-        if (acl.mChannelLayoutTag == 0) acl = GetDefaultChannelLayout(&asbd);
@@ -634 +634 @@
-        } else if ((*imgDesc)->cType == kSubFormatUTF8 || (*imgDesc)->cType == kSubFormatSSA || (*imgDesc)->cType == kSubFormatASS) {
-                if ((*imgDesc)->cType == kSubFormatASS) (*imgDesc)->cType = kSubFormatSSA; // no real reason to treat them differently
-XXX
+FIXME:
-                mkvTrack.subDataRefHandler = NewHandleClear(sizeof(Handle) + 1);
-                emptyDataRefExtension[0] = EndianU32_NtoB(sizeof(UInt32)*2);

trunk/Subtitles/SubATSUIRenderer.m

@@ -263 +263 @@
-}
-
-XXX: 
+
-static ATSUFontID GetFontIDForSSAName(NSString *name)
-{       
@@ -355 +355 @@
-        
-        if (!s->platformSizeScale) s->platformSizeScale = GetWinFontSizeScale(fontRef);
-
+:
-        
-        ATSUCreateStyle(&style);
@@ -440 +440 @@
-        switch (tag) {
-                case tag_b:
-XXX
+FIXME:
-                        SetATSUStyleFlag(spanEx->style, kATSUQDBoldfaceTag, bval != 0);
-                        break; 
@@ -555 +555 @@
-                case tag_be:
-                        bv();
- XXX
+FIXME:
-                        spanEx->blurEdges = bval;
-                        break;
@@ -565 +565 @@
-#pragma mark Rendering Helper Functions
-
-XXX 
+
-static ATSUTextMeasurement GetLineHeight(ATSUTextLayout layout, UniCharArrayOffset lpos, Boolean includeDescent)
-{
@@ -584 +584 @@
-}
-
-XXX 
+
-// it should be checked against the real pixel box (see #if 0 below), but for correct fonts it looks much better
-static void GetTypographicRectangleForLayout(ATSUTextLayout layout, UniCharArrayOffset *breaks, ItemCount breakCount, Fixed extraHeight, Fixed *lX, Fixed *lY, Fixed *height, Fixed *width)
@@ -955 +955 @@
-        //ATS bug(?) with some fonts:
-        //drawing \n draws some random other character, so skip them
-XXX
+FIXME:
-        if ([div->text characterAtIndex:thisBreak+lineLen-1] == '\n') {
-                lineLen--;
@@ -1001 +1001 @@
-                        
-                        //linear search for the next span to draw
-XXX not at all sure how this works or if it's correct
+FIXME: make sure this never skips any spans
-                        for (j = 0; j < nspans; j++) {
-                                SubRenderSpan *span = [div->spans objectAtIndex:j];
@@ -1370 +1370 @@
-// Windows and OS X use different TrueType fields to measure text.
-// Some Windows fonts have one field set incorrectly(?), so we have to compensate.
-XXX
-XXX^2 
+FIXME:
+
-static float GetWinFontSizeScale(ATSFontRef font)
-{

trunk/Subtitles/SubRenderer.h

@@ -37 +37 @@
-#endif
-
-XXX 
+
-@interface SubRenderer : NSObject
--(void)completedHeaderParsing:(SubContext*)sc;

trunk/TextSubCodec.c

@@ -222 +222 @@
-    
-    // we want ARGB because Quartz can use it easily
-    // Todo: add other possible pixel formats Quartz can handle
-    *formats++  = k32RGBAPixelFormat;
-        *formats++      = k32ARGBPixelFormat;

trunk/bitstream_info.c

@@ -1030 +1030 @@
-                //QT is bad at high profile
-                //and x264 B-pyramid (sps.vui.num_reorder_frames > 1)
-                //FIXME x264 will generate pyramid differently soon (core 78+), and that might work better
-                if(h264parser->profile_idc < 100 && h264parser->num_reorder_frames < 2 && 
-                   !CFPreferencesGetAppBooleanValue(CFSTR("DecodeAllProfiles"), PERIAN_PREF_DOMAIN, NULL))

trunk/codecList.m4

@@ -8 +8 @@
-Codec(kXVIDCodecInfoResID, CODEC_ID_MPEG4, "Xvid", "Decompresses video stored in Xvid format.", 'XVID', 'xvid', 'XviD', 'XVIX', 'BLZ0')
-Codec(kMPEG4CodecInfoResID, CODEC_ID_MPEG4, "MPEG-4", "Decompresses video stored in MPEG-4 format.", 'RMP4', 'SEDG', 'WV1F', 'FMP4', 'SMP4')
-XXX
+FIXME
-ResourceOnly(<!#define kCodecManufacturer 'appl'!>)
-ResourceOnly(<!#define kCodecVersion kFFusionCodecVersion + 0x10!>)

trunk/ff_private.c

@@ -126 +126 @@
-        av_reduce(&base->num, &base->den, base->num, base->den, INT_MAX);
-        
-XXX
+FIXME:
-        
-        double fTimebase = av_q2d(*base), nearest_ntsc = floor(fTimebase * 1001. + .5) / 1001.;
@@ -188 +188 @@
-        
-        // 12 is invalid in mov
-XXX
+FIXME:
-        if ((*imgHdl)->depth == 12 || (*imgHdl)->depth == 0) (*imgHdl)->depth = codec->pix_fmt == PIX_FMT_YUVA420P ? 32 : 24;
-        
@@ -228 +228 @@
-        
-        /* Ask the AudioToolbox about vbr of the codec */
-
+:
-        // which means our mBytesPerPacket is wrong for CBR mp3 (does not really matter)
-        ioSize = sizeof(UInt32);
@@ -281 +281 @@
-                asbd.mFramesPerPacket = 1;
-        else if (asbd.mBytesPerPacket) {
-.
+:
-                 * of the difference in the sample_rate and the time_base denumerator. So we
-                 * recalculate here the mFramesPerPacket entry */
@@ -619 +619 @@
-
-// Create the 'nclc' atom for video tracks. Guessed entirely from image size following ffdshow.
-
+:
-// this needs the parsers working
-// References: http://developer.apple.com/quicktime/icefloe/dispatch019.html
@@ -690 +690 @@
-                        track = NewMovieTrack(theMovie, width, height, kNoVolume);
-
-XXX 
+
-            if( st->codec->codec_id == CODEC_ID_NUV && st->codec->codec_tag == 0 ) {
-                st->codec->codec_tag = MKTAG( 'N', 'U', 'V', '1' );