Changeset 346

Timestamp:

02/21/07 14:34:57 (2 years ago)

Author:

astrange

Message:

Fix "flag" machine. (closes #109)
Turn on unused variables warning, which reveals a lot of them in our code. No time to fix them now...

Files:

• trunk/Perian.xcodeproj/project.pbxproj (modified) (4 diffs)
• trunk/SSATagParsing.m.rl (modified) (2 diffs)
• trunk/TextSubCodec.c (modified) (1 diff)

trunk/Perian.xcodeproj/project.pbxproj

@@ -1809 +1809 @@
-                                GCC_WARN_ABOUT_RETURN_TYPE = YES;
-                                GCC_WARN_TYPECHECK_CALLS_TO_PRINTF = YES;
+                                GCC_WARN_UNUSED_VARIABLE = YES;
-                                HEADER_SEARCH_PATHS = (
-                                        ffmpeg/libavcodec,
@@ -1867 +1868 @@
-                                GCC_WARN_TYPECHECK_CALLS_TO_PRINTF = YES;
-                                GCC_WARN_UNINITIALIZED_AUTOS = YES;
+                                GCC_WARN_UNUSED_VARIABLE = YES;
-                                HEADER_SEARCH_PATHS = (
-                                        ffmpeg/libavcodec,
@@ -1922 +1924 @@
-                                GCC_WARN_TYPECHECK_CALLS_TO_PRINTF = YES;
-                                GCC_WARN_UNINITIALIZED_AUTOS = YES;
+                                GCC_WARN_UNUSED_VARIABLE = YES;
-                                HEADER_SEARCH_PATHS = (
-                                        ffmpeg/libavcodec,
@@ -2083 +2086 @@
-                                GCC_WARN_TYPECHECK_CALLS_TO_PRINTF = YES;
-                                GCC_WARN_UNINITIALIZED_AUTOS = YES;
+                                GCC_WARN_UNUSED_VARIABLE = YES;
-                                HEADER_SEARCH_PATHS = (
-                                        ffmpeg/libavcodec,

trunk/SSATagParsing.m.rl

@@ -544 +544 @@
-                                }
-                                
-ag == '0' || flag == '1') flag = fl - '0';})? > {flag = 1
+ == '0' || fl == '1') flag = fl - '0';})? > {flag = 0
-                                num_ = "-"? digit+ ('.' digit*)?;
-                                num = num_ > {numbegin = p;} % {num = [[NSString stringWithCharacters:numbegin length:p-numbegin] doubleValue];};
@@ -584 +584 @@
-                                                                );
-                                
- 
+
-                                
-                                tag = "{" ((cmd*) | ([^\\}]*)) "}";

trunk/TextSubCodec.c

@@ -304 +304 @@
-                buf = CFStringCreateMutableWithBytes(NULL, drp->codecData, myDrp->dataSize, kCFStringEncodingUTF8);
-                if (!buf) return noErr;
-
-
+1
+1
-                CFStringFindAndReplace(buf, CFSTR("</i>"), CFSTR("{\\i0}"), CFRangeMake(0,CFStringGetLength(buf)), 0);
-                CFStringFindAndReplace(buf, CFSTR("</b>"), CFSTR("{\\b0}"), CFRangeMake(0,CFStringGetLength(buf)), 0);