Changeset 452

Timestamp:

04/19/07 21:35:48 (1 year ago)

Author:

gbooker

Message:

More robust version checking and corrected some version numbers.

Files:

• trunk/CPFPerianPrefPaneController.m (modified) (5 diffs)
• trunk/Plists/PerianPane-Info.plist (modified) (1 diff)
• trunk/Plists/PerianUpdateChecker-Info.plist (modified) (1 diff)

trunk/CPFPerianPrefPaneController.m

@@ -7 +7 @@
-#define LastInstalledVersionKey CFSTR("LastInstalledVersion")
-
+@interface NSString (VersionStringCompare)
+- (BOOL)isVersionStringOlderThan:(NSString *)older;
+@end
+
+@implementation NSString (VersionStringCompare)
+- (BOOL)isVersionStringOlderThan:(NSString *)older
+{
+        if([self compare:older] == NSOrderedAscending)
+                return TRUE;
+        if([self hasPrefix:older] && [self length] > [older length] && [self characterAtIndex:[older length]] == 'b')
+                //1.0b1 < 1.0, so check for it.
+                return TRUE;
+        return FALSE;
+}
+@end
+
-@interface CPFPerianPrefPaneController(_private)
-- (void)setAC3DynamicRange:(float)newVal;
@@ -132 +148 @@
-        {
-                NSString *currentVersion = [infoDict objectForKey:BundleVersionKey];
-compare:myVersion] == NSOrderedAscending
+isVersionStringOlderThan:myVersion]
-                        ret = InstallStatusOutdated;
-
-ret = InstallStatusInstalled;          
+else
+       ret = InstallStatusInstalled;
-        }
-        
@@ -147 +163 @@
-        
-        return setWrongLocationInstalled(ret);
+}
+
+- (void)setInstalledVersionString
+{
+        NSString *path = [[self basePathForType:ComponentTypeQuickTime user:userInstalled] stringByAppendingPathComponent:@"Perian.component"];
+        
+        NSDictionary *infoDict = [NSDictionary dictionaryWithContentsOfFile:[path stringByAppendingPathComponent:@"Contents/Info.plist"]];
+        if(infoDict != nil)
+        {
+                NSString *currentVersion = [infoDict objectForKey:BundleVersionKey];
+                [textField_currentVersion setStringValue:currentVersion];
+        }
+        else
+                [textField_currentVersion setStringValue:@"-"];
-}
-
@@ -175 +205 @@
-{
-        NSDictionary *infoDict = [[self bundle] infoDictionary];
-
+
+
+
+
-        if(currentInstallStatus(installStatus) == InstallStatusNotInstalled)
-        {
@@ -242 +275 @@
-    NSString *lastInstVersion = [self getStringFromKey:LastInstalledVersionKey forAppID:perianAppID];
-    NSString *myVersion = [[[self bundle] infoDictionary] objectForKey:BundleVersionKey];
-compare:myVersion] == NSOrderedAscending
+isVersionStringOlderThan:myVersion]
-    {
-        /*Check for temp after an update */

trunk/Plists/PerianPane-Info.plist

@@ -33 +33 @@
-        <string>????</string>
-        <key>CFBundleVersion</key>
-
+b1
-        <key>CFBundleName</key>
-        <string>Perian</string>

trunk/Plists/PerianUpdateChecker-Info.plist

@@ -18 +18 @@
-        <string>????</string>
-        <key>CFBundleVersion</key>
-0.5
+1.0b1
-        <key>NSMainNibFile</key>
-        <string>UpdateCheckerMainMenu</string>