Changeset 913

Show
Ignore:
Timestamp:
07/06/08 16:40:47 (5 months ago)
Author:
astrange
Message:

Fix a compile-breaking typo in the last one, oops.
Also another really bad typo in the update checker.
Fix some bugs reported by Clang static analysis.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • trunk/FFusionCodec.c

    r908 r913  
    17101710        {             
    17111711            got_picture = 0; 
    1712             len = 1; 
    17131712                        Codecprintf(glob->fileLog, "Error while decoding frame\n"); 
    17141713             

  • trunk/GBPerianPanePListGenerator.m

    r378 r913  
    5353        [plist setObject:components forKey:ComponentInfoDictionaryKey]; 
    5454        [plist writeToFile:[NSString stringWithUTF8String:argv[3]] atomically:YES]; 
     55    [plist release]; 
    5556        [pool release]; 
    5657         

  • trunk/Update Checker Sources/NSString+extras.m

    r269 r913  
    8181         
    8282        [componentsCopy removeObjectsInRange: NSMakeRange (ix, len - ix)]; 
     83    [componentsCopy autorelease]; 
    8384 
    8485        return [componentsCopy componentsJoinedByString: @" "]; 

  • trunk/Update Checker Sources/UpdateCheckerAppDelegate.m

    r624 r913  
    9191                [[NSApplication sharedApplication] terminate:self]; 
    9292        } 
     93     
     94    [appcast release]; 
    9395} 
    9496 
    …… 
    98100        if(manualRun) 
    99101                [self showUpdateErrorAlertWithInfo:SULocalizedString(@"An error occurred while trying to load Perian's version info. Please try again later.", nil)]; 
     102    [appcast release]; 
    100103        [[NSApplication sharedApplication] terminate:self];      
    101104} 

  • trunk/Update Checker Sources/main.m

    r834 r913  
    1616{ 
    1717        int fp = open(lockPath, O_CREAT | O_EXCL); 
    18         if(fp = -1) 
     18        if(fp == -1) 
    1919        { 
    2020                struct stat lockfile; 
    …… 
    3434        int ret = NSApplicationMain(argc,  (const char **) argv); 
    3535         
     36    close(fp); 
    3637        unlink(lockPath); 
    3738         

  • trunk/createStaticLibs.sh

    r912 r913  
    2828fi  
    2929 
    30 if [ $CC = "" ]; then 
     30if [ "$CC" = "" ]; then 
    3131        CC="gcc" 
    3232        export CC 

  • trunk/ff_private.c

    r897 r913  
    11371137                 
    11381138                if(err == noErr) 
    1139                         err = MovieExecuteWiredActions(movie, 0, container); 
     1139                        MovieExecuteWiredActions(movie, 0, container); 
    11401140                 
    11411141                err = QTDisposeAtomContainer(container);