Ticket #102 (closed defect: fixed)

Opened 3 years ago

Last modified 23 months ago

Matroska importer inserts empty frames

Reported by: roine@… Owned by:
Priority: normal Milestone: Sometime after 1.0
Component: matroska Version:
Severity: normal Keywords:
Cc:

Description

AddTrack?() does not verify that a frame has a non-zero duration, and will try to insert frames with zero duration which QuickTime will reject with -2014 invalidDuration.

Change History

Changed 3 years ago by dconrad

I'm pretty sure that Matroska requires timecodes to be increasing, so if we try to insert a frame with zero duration, that probably means that we've screwed up calculating the duration. I know that we do so for formats with out-of-order frames (#30, which I should fix soon). I think trac allows attachments up to ~200k, so if you have a file that isn't covered by #30 where this occurs in the first 200k, could you attach that or upload it somewhere else if it doesn't occur until later in the file?

I'll add a return so that we don't continue calling functions as though it were added, but is there any reason to specifically check for a 0 duration beforehand rather than bail on a -2014 return?

Changed 3 years ago by dconrad

(In [328]) Bail on error adding sample in AddFrame?(). Refs #102

Changed 3 years ago by tick

  • milestone set to 1.0

Did [328] fix this?

Changed 3 years ago by tick

  • milestone changed from 1.0 to Sometime after 1.0

Move back to 1.0 if there are any objections

Changed 23 months ago by astrange

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.