Ticket #390 (new defect)

Opened 5 years ago

Last modified 5 years ago

SVN revision scripts error if .svn isn't found

Reported by: astrange Owned by:
Priority: normal Milestone: 1.3
Component: Perian-Main Version: 1.1.2
Severity: normal Keywords:
Cc:

Description

The scripts that set the SVN versions for Perian and ffmpeg print errors if you try building from an svn export. This doesn't interrupt the build but is pretty annoying, and also probably results in a bad version string for any binary not built from SVN.

Change History

comment:1 Changed 5 years ago by gbooker

Given that there's no svn revision information in an export, what would be the best fallback here?

comment:2 Changed 5 years ago by astrange

Maybe have 'make release' build a source tarball with the SVN revisions in a header?

comment:3 Changed 5 years ago by tick

Just put an if .svn, do foo, else if not .svn, end/break/whatever.

comment:4 Changed 5 years ago by astrange

I think we might as well try not to do this, since we want revisions in the version string.

Note: See TracTickets for help on using tickets.